This comparison evaluates the performance of Shadow Priests and Survival Hunters, highlighting their strengths and weaknesses. Using SimulationCraft, each spec was tested under various conditions to analyze their capabilities in level 80 end-game PvE gameplay. Updated for patch 11.0.5 of the The War Within expansion.
Performance ComparisonPatch 11.0.5
Survival Hunter+2.59% DPS
When simulating for maximum theoretical single-target DPS, Survival Hunters averaged 2.59% more DPS than Shadow Priests (+41K DPS).
Survival Hunter+38.14% DPS
When simulating for light AoE DPS potential, with small waves of adds, Survival Hunters averaged 38.14% more DPS than Shadow Priests (+933K DPS).
Shadow Priest+0.93% DPS
When upgrading the gear for both specs by +44 ilvl, Shadow Priest DPS improved the most, +0.93% more than Survival Hunter. In total, Shadow Priests DPS increased by 66.77% and Survival Hunters by 65.84%.
This category evaluates the burst DPS potential of each spec by simulating a short encounter with full raid buffs and bloodlust.
This category evaluates the solo DPS potential of each spec by simulating a typical solo delve encounter with no raid buffs.
This category evaluates the pure AoE DPS potential of each spec by simulating both specs to fight intense groups of adds, with nearly 16 adds at any given moment.
This category evaluates the performance of each spec when introducing occasional movement and stuns during boss encounters.
This category evaluates the latency tolerance of each spec by simulating both specs with moderate-to-high latency. This can indicate which spec performs better when facing high latency, whether due to far server/realm location or limited access to quality internet.
This category evaluates the skill level required to play each spec by simulating both specs with greatly reduced player skill. This can indicate which spec is more forgiving of mistakes or has a simpler rotation.
The comparisons above highlight some of the key differences between Shadow Priest and Survival Hunter in the current meta, which can hopefully help you determine which spec to play or group up with.
Shadow Priestvs Survival Hunter
Survival Hunter+2.59% DPS 
Shadow Priest+0.93% DPS